Messages in this thread |  | | Date | Tue, 22 Dec 2015 11:04:46 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup() |
| |
On Mon, Dec 21, 2015 at 12:46:51AM +0300, Alexey Khoroshilov wrote: > diff --git a/drivers/staging/wilc1000/wilc_wlan.c b/drivers/staging/wilc1000/wilc_wlan.c > index a73e99f..4b7c8e9 100644 > --- a/drivers/staging/wilc1000/wilc_wlan.c > +++ b/drivers/staging/wilc1000/wilc_wlan.c > @@ -1459,15 +1459,16 @@ void wilc_wlan_cleanup(struct net_device *dev) > ret = p->hif_func.hif_read_reg(wilc, WILC_GP_REG_0, ®); > if (!ret) { > PRINT_ER("Error while reading reg\n"); > - release_bus(wilc, RELEASE_ALLOW_SLEEP); > + goto _unlock;
If you're redoing this anyway, could we get rid of the underscore in the label name? Just unlock: is fine.
regards, dan carpenter
|  |