Messages in this thread |  | | Date | Mon, 21 Dec 2015 09:42:32 -0800 | From | Davidlohr Bueso <> | Subject | Re: [PATCH] futex: Prevent pi_state from double freeing in case of error |
| |
On Sat, 19 Dec 2015, Darren Hart wrote:
>On Sat, Dec 19, 2015 at 07:24:38PM +0100, Thomas Gleixner wrote: >> - Why are the reviews so sloppy and useless? >> >> The one I'm answering to is just hillarious and the other one picks >> a random commit, claims that it inadvertantly introduced the issue >> and is done with it. Really helpful. >> >> Folks, this is not the way it works. It took me a couple of hours to >> get this analyzed properly, but I don't see that anyone involved in >> this thread has spent more than a few seconds on it. >> >> At least I found a real issue related to this refcount stuff, but I >> would have preferred that the people involved in this would have found >> it in the first place instead of providing half baken crap. >> >> Yours grumpy >> >> tglx > >More care was clearly warranted on my part. I thought I saw the connection with >the previous commit I referenced (it wasn't random!), but clearly didn't dig >deep enough.
Same here. I hadn't looked at it long enough, so while I was hesitant of sending a full review/ack, I should not have sent a half-arse answer either. Apologies.
Thanks, Davidlohr
|  |