[lkml]   [2015]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v5] extcon: add Maxim MAX3355 driver

On 12/21/2015 5:38 AM, Chanwoo Choi wrote:

>>> This patch depend on GPIOLIB configuration as following:
>>> I modified it with following diff and applied it.
>>> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
>>> index ba4db7d..3d89e60 100644
>>> --- a/drivers/extcon/Kconfig
>>> +++ b/drivers/extcon/Kconfig
>>> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>>> config EXTCON_MAX3355
>>> tristate "Maxim MAX3355 USB OTG EXTCON Support"
>>> + depends on GPIOLIB || COMPILE_TEST
>> If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
>> And no, it shouldn't depend on gpiolib. It has empty stubs for the case of CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll look into it.
> Yes. When GPIOLIB is disabled, the build issue don't happen.

What? It surely does happen!

> because include/linux/gpio/consumer.h implement the dummy function
> for all gpio functions if CONFIG_GPIOLIB is disabled.

Linus W. advised to #include this header explicitly -- I'll try and post.

> For correct operation of max3355, you should add the dependency
> to the extcon-max3355.c driver. This driver use the GPIO library
> certainly.

I disagree. The driver will just cease to load in this case. I don't see
why we need such dependency. Only compilation time dependencies should be
specified, I think.

> COMPILE_TEST is used for just build test. You can see the detailed data[1].
> [1]

I know. Re-read my question please.

> Thanks,
> Chanwoo Choi

MBR, Sergei

 \ /
  Last update: 2015-12-21 12:21    [W:0.055 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site