Messages in this thread |  | | From | Andy Lutomirski <> | Date | Sun, 20 Dec 2015 04:20:39 -0800 | Subject | firmware_class warnings on resume |
| |
I hit this warning fairly frequently when resuming 4.4-rc5:
ret = usermodehelper_read_trylock(); if (WARN_ON(ret)) { dev_err(device, "firmware: %s will not be loaded\n", name); goto out; }
It seems like it could be improved in two ways fairly easily:
1. Shouldn't firmware_class try the direct load before trying to get the usermodehelper lock?
2. Why is the !NOWAIT case doing a trylock? That seems wrong.
--Andy
-- Andy Lutomirski AMA Capital Management, LLC
|  |