Messages in this thread |  | | Date | Sun, 20 Dec 2015 12:46:02 +0100 | From | Alexandre Belloni <> | Subject | Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting |
| |
On 07/12/2015 at 14:49:34 +0100, Juergen Borleis wrote : > When setting a new time/date the RTC's clock must be stopped first, in > order to write the time/date registers in an atomic manner. > So, this change stops the clock first and then writes the time/date > registers and the clock control register (to re-enable the clock) in one > turn. >
I'd have the same comment for that patch. Using i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the code clearer and also more robust because it takes care of retransmissions for example.
-- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
|  |