Messages in this thread |  | | Date | Sun, 20 Dec 2015 15:10:49 -0800 | Subject | Re: [PATCH v5 3/5] PCI: qcom: Add Qualcomm PCIe controller driver | From | Bjorn Andersson <> |
| |
On Fri, Dec 18, 2015 at 5:44 AM, kbuild test robot <lkp@intel.com> wrote: > Hi Stanimir, > > [auto build test WARNING on next-20151218] > [also build test WARNING on v4.4-rc5] > [cannot apply to pci/next robh/for-next v4.4-rc5 v4.4-rc4 v4.4-rc3] > > url: https://github.com/0day-ci/linux/commits/Stanimir-Varbanov/Qualcomm-PCIe-driver-and-designware-fixes/20151218-205427 > > > coccinelle warnings: (new ones prefixed by >>) > >>> drivers/pci/host/pcie-qcom.c:188:1-3: WARNING: PTR_ERR_OR_ZERO can be used > drivers/pci/host/pcie-qcom.c:220:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > Please review and possibly fold the followup patch. >
I disagree with this "recommendation" as it's only outcome will be asymmetry.
I think this script should be changed to only warn if there's a single IS_ERR/PTR_ERR at the end of the function, not if there's a list of them and this would replace the last one.
Regards, Bjorn
|  |