Messages in this thread |  | | Date | Sun, 20 Dec 2015 19:16:16 +0200 | Subject | Re: [PATCH RESEND 1/1] serial: 8250_pci: Fix real serial port count for F81504/508/512 | From | Andy Shevchenko <> |
| |
On Tue, Dec 15, 2015 at 4:56 AM, Peter Hung <hpeter@gmail.com> wrote: > Andy Shevchenko 於 2015/12/13 上午 09:08 寫道: >> >> On Tue, Dec 1, 2015 at 8:54 AM, Peter Hung <hpeter@gmail.com> wrote: >>> +/* The device is multi-function with UART & GPIO */ >>> +static u8 fintek_gpio_mapping[] = {2, 3, 8, 9, 10, 11}; >> >> >> Clearly you have bit combination here >> Bit 1: 1 >> Bit 3: 1 >> >> So, mask as 0x0a shall cover this IIAC. > > > IMO, It maybe wrong. If we checked only with 0x0a mask, > the 0x06 & 0x07 will be passed.
Ah, yes, it will be a bit more than just one check, something like: (x & 0x0a) && (x & 0x0e != 6)
-- With Best Regards, Andy Shevchenko
|  |