lkml.org 
[lkml]   [2015]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/7] perf: Generalize task_function_call()ers
    Date
    Peter Zijlstra <peterz@infradead.org> writes:

    > On Fri, Dec 18, 2015 at 05:07:34PM +0200, Alexander Shishkin wrote:
    >> Peter Zijlstra <peterz@infradead.org> writes:
    >>
    >> > @@ -2774,9 +2696,6 @@ static void perf_event_context_sched_in(
    >> > */
    >> > cpu_ctx_sched_out(cpuctx, EVENT_FLEXIBLE);
    >> >
    >> > - if (ctx->nr_events)
    >> > - cpuctx->task_ctx = ctx;
    >> > -
    >> > perf_event_sched_in(cpuctx, cpuctx->task_ctx, task);
    >>
    >> This then should probably become
    >>
    >> perf_event_sched_in(cpuctx, ctx, task);
    >>
    >> otherwise task contexts just don't get scheduled any more.
    >
    > Very good, thanks!
    >
    > Running with that triggers another WARN, I'll have a look at that later
    > tonight.

    Hmm, is it the one from event_function() where a task context is
    scheduled, but is inactive and/or doesn't have events?

    I think there's also more fun to be had there now that you've started
    digging it up, I'll also poke at it more later today.

    Regards,
    --
    Alex


    \
     
     \ /
      Last update: 2015-12-18 19:21    [W:19.262 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site