Messages in this thread |  | | Date | Wed, 4 Nov 2015 13:21:51 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c |
| |
On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: > On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: > > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. > > > > The names in here are so generic that I don't think it's a good idea > > to expose them to userspace (or even the rest of the kernel). Since > > there's only one kernel user, it's been moved to that file. > > > > Signed-off-by: Palmer Dabbelt <palmer@dabbelt.com> > > Reviewed-by: Andrew Waterman <waterman@eecs.berkeley.edu> > > Reviewed-by: Albert Ou <aou@eecs.berkeley.edu> > > Assuming you want to keep all these patches together in a tree or so. > Let me know if you want me to take this patch. > > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Ah, build-bot finds your change is broken and you didn't grep right. It is used in more places.
How about moving it to include/linux/hw_breakpoint.h, instead of having it in the uapi crud?
|  |