lkml.org 
[lkml]   [2015]   [Oct]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 1/9] Input: goodix - sort includes alphabetically
Hi!

> > Subject: Re: [PATCH v5 1/9] Input: goodix - sort includes alphabetically
> >
> > On Mon 2015-09-07 17:36:15, Irina Tirdea wrote:
> > > Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
> > > ---
> > > drivers/input/touchscreen/goodix.c | 12 ++++++------
> > > 1 file changed, 6 insertions(+), 6 deletions(-)
> >
> > Don't.
> >
> > Yes, we sometimes sort includes... to avoid patch rejects.
> >
> > This is guaranteed to cause rejects.
> >
> > If we do sort them, we use "longest-first" usually.
> >
>
> When using random order, I've been told by reviewers that my ordering
> is wrong [1], but I could not figure out what the "right" ordering is in order to apply.
> I did not find any mention of how to sort includes in Documentation/CodingStyle,
> but I've seen patches in the kernel that fix random ordering by sorting them
> alphabetically [2].

Ok, I have seen this more often:

https://lkml.org/lkml/2009/3/28/99

> However, I do not feel strongly about this so I can drop this patch.

Well, its really nit picking.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2015-10-05 23:21    [W:0.058 / U:12.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site