lkml.org 
[lkml]   [2015]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v4] bcma: fix two coding style issues, more than 80 characters per line.
Date
Rafał Miłecki <zajec5@gmail.com> writes:

> On 7 January 2015 at 18:55, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Oscar Forner Martinez <oscar.forner.martinez@gmail.com> writes:
>>
>>> Two lines with more than 80 characters per line have been split in several lines.
>>>
>>> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>
>>
>> Thanks, applied to wireless-drivers-next.git.
>
> Could you still replace it (V4) with an older version (V3)? Before I
> explained V3 was OK Oscar already sent this (worse) V4.

No. I'm not going to rebase a public git tree unless there's a huge
disaster.

But if I see V4 I'm going to assume that's the one I need to apply, not
some older version. If V4 is not good for some reason, make it
ABSOLUTELY clear that I should not apply it. I do not want to start
guessing what patch I should apply.

> This is not critical though, we can always send separated patch for
> one more line > 80 chars.

Please send a followup patch if you want to fix something.

--
Kalle Valo


\
 
 \ /
  Last update: 2015-01-07 20:01    [W:2.526 / U:1.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site