lkml.org 
[lkml]   [2015]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] perf tools: Append callchains only when requested
Em Sun, Jan 04, 2015 at 12:01:26AM +0900, Namhyung Kim escreveu:
> On Sat, Jan 3, 2015 at 11:25 AM, Arnaldo Carvalho de Melo
> <acme@kernel.org> wrote:
> > Em Mon, Dec 22, 2014 at 01:44:14PM +0900, Namhyung Kim escreveu:
> >> The perf report --children can be called with callchain disabled so no
> >> need to append callchains. Actually the root of callchain tree is not
> >> initialized properly in this case.

> > I should have caught this using 'perf test', but it slipped
> > thru, please try running 'perf test cumulation', I noticed that it fails
> > and that if I revert this changeset it works again, can you please
> > check?

> This change should not affect the test result, but I guess the test
> somehow relied on the undefined behavior. Actually I posted a patch
> to fix this problem. So please take a look at the link below:

> https://lkml.org/lkml/2014/12/22/561

Ok, missed this one, will get it on perf/urgent and look if there are
patches pending merging in that pull req.

Thanks,

- Arnaldo


\
 
 \ /
  Last update: 2015-01-05 14:01    [W:0.073 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site