lkml.org 
[lkml]   [2015]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/10] iio: imu: kmx61: Don't ignore kmx61_set_power_state errors
On 01/01/15 13:45, Hartmut Knaack wrote:
> Daniel Baluta schrieb am 23.12.2014 um 14:22:
>> ..except while in an error handler, where there is nothing
>> to be done anyway.
>>
>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> Reviewed-by: Hartmut Knaack <knaack.h@gmx.de>
Applied
>> ---
>> drivers/iio/imu/kmx61.c | 11 +++++++++--
>> 1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/iio/imu/kmx61.c b/drivers/iio/imu/kmx61.c
>> index fe0cee7..e9cbd91 100644
>> --- a/drivers/iio/imu/kmx61.c
>> +++ b/drivers/iio/imu/kmx61.c
>> @@ -830,7 +830,12 @@ static int kmx61_read_raw(struct iio_dev *indio_dev,
>> }
>> mutex_lock(&data->lock);
>>
>> - kmx61_set_power_state(data, true, chan->address);
>> + ret = kmx61_set_power_state(data, true, chan->address);
>> + if (ret) {
>> + mutex_unlock(&data->lock);
>> + return ret;
>> + }
>> +
>> ret = kmx61_read_measurement(data, base_reg, chan->scan_index);
>> if (ret < 0) {
>> kmx61_set_power_state(data, false, chan->address);
>> @@ -839,9 +844,11 @@ static int kmx61_read_raw(struct iio_dev *indio_dev,
>> }
>> *val = sign_extend32(ret >> chan->scan_type.shift,
>> chan->scan_type.realbits - 1);
>> - kmx61_set_power_state(data, false, chan->address);
>> + ret = kmx61_set_power_state(data, false, chan->address);
>>
>> mutex_unlock(&data->lock);
>> + if (ret)
>> + return ret;
>> return IIO_VAL_INT;
>> case IIO_CHAN_INFO_SCALE:
>> switch (chan->type) {
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>



\
 
 \ /
  Last update: 2015-01-04 12:21    [W:0.056 / U:0.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site