lkml.org 
[lkml]   [2015]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 08/15] media: blackfin: bfin_capture: use vb2_ioctl_* helpers
From
2014-12-20 18:47 GMT+08:00 Lad, Prabhakar <prabhakar.csengg@gmail.com>:
> this patch adds support to vb2_ioctl_* helpers.
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> drivers/media/platform/blackfin/bfin_capture.c | 107 +++++--------------------
> 1 file changed, 22 insertions(+), 85 deletions(-)
>
> diff --git a/drivers/media/platform/blackfin/bfin_capture.c b/drivers/media/platform/blackfin/bfin_capture.c
> index 30f1fe0..80a0efc 100644
> --- a/drivers/media/platform/blackfin/bfin_capture.c
> +++ b/drivers/media/platform/blackfin/bfin_capture.c
> @@ -272,15 +272,28 @@ static int bcap_start_streaming(struct vb2_queue *vq, unsigned int count)
> struct ppi_if *ppi = bcap_dev->ppi;
> struct bcap_buffer *buf, *tmp;
> struct ppi_params params;
> + dma_addr_t addr;
> int ret;
>
> /* enable streamon on the sub device */
> ret = v4l2_subdev_call(bcap_dev->sd, video, s_stream, 1);
> if (ret && (ret != -ENOIOCTLCMD)) {
> v4l2_err(&bcap_dev->v4l2_dev, "stream on failed in subdev\n");
> + bcap_dev->cur_frm = NULL;
> goto err;
> }
>
> + /* get the next frame from the dma queue */
> + bcap_dev->cur_frm = list_entry(bcap_dev->dma_queue.next,
> + struct bcap_buffer, list);
> + /* remove buffer from the dma queue */
> + list_del_init(&bcap_dev->cur_frm->list);
> + addr = vb2_dma_contig_plane_dma_addr(&bcap_dev->cur_frm->vb, 0);
> + /* update DMA address */
> + ppi->ops->update_addr(ppi, (unsigned long)addr);
> + /* enable ppi */
> + ppi->ops->start(ppi);
> +

Absolutely wrong here. You can't start ppi before you set ppi params.
In fact vb2_streamon() is called before this in bcap_streamon().


\
 
 \ /
  Last update: 2015-01-21 12:01    [W:0.096 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site