lkml.org 
[lkml]   [2015]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: iio: dht11 Updates
Am 01.01.2015 um 22:18 schrieb harald@ccbib.org:
> Hi!
>
> On Thu, 01 Jan 2015 12:38:23 +0000, Jonathan Cameron <jic23@kernel.org>
> wrote:
>> On 02/12/14 23:32, Richard Weinberger wrote:
>>> Please see my current patches for your driver.
>>> As discussed in an earlier mail I'm testing with the DHT22 sensor only.
>>> With the IRQ changes I see 84 edges.
>>>
>>>
>>> [PATCH 1/4] iio: dht11: Add locking
>>> [PATCH 2/4] iio: dht11: IRQ fixes
>>> [PATCH 3/4] iio: dht11: Logging updates
>>> [PATCH 4/4] iio: dht11: Fix out-of-bounds read
>>>
>
>> I've lost track of where we are with this patch series.
>> Does this cause trouble on any of the parts supported?
>
> Yes, 2/4 needs an update.

Correct.

> 1/4 is fine by me, however it was noted that there is already
> locking in the iio core for the in-kernel interface but not
> for the sysfs interface. I think we need locking in the case of
> the sysfs interace as well, but the final decision is yours...

We definitely need it.
I have more than one sensor attached and collectd queries them.
Without locking collectd manages to hit this race window.
So the issue is real.

> 4/4 is obviously right.
>
> 3/4 is cleanup. I'd rather defer this to later and do it right,
> because right now this patch is cosmetic and doesn't get rid of
> the deeper issues. I'll start to work on a cleanup series once
> the fixes are merged.

Agreed.

> Richard, what's your timeframe to send an updated series?
> I can send an update if you don't have time.

It would be great if you can send an updated version of 2/4.
I don't have a DHT11 sensor (only DHT22) and I'm still recovering
from a cold.

Thanks
//richard


\
 
 \ /
  Last update: 2015-01-02 12:41    [W:0.205 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site