lkml.org 
[lkml]   [2015]   [Jan]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 0/2] ASoC: tda998x: add a codec to the HDMI transmitter
On 12/30/2014 07:00 PM, Mark Brown wrote:
> On Mon, Dec 29, 2014 at 07:37:21PM +0200, Jyri Sarha wrote:
>> On 12/29/2014 06:52 PM, Mark Brown wrote:
>
>>> So, I'm not seeing *any* interest here from any other HDMI users. This
>>> is a continuing theme with HDMI patches and is really very concerning,
>>> everyone appears to be working in their own bubbles coming up with their
>>> own things and ignoring everyone else's work - what little review I'm
>
>> I have not seen any significant new development since v7 of these patches.
>> My comments for v6 were mostly[1] addressed and I can live with these
>> changes, even develop this approach further if it gets merged.
>
> OK, so this sort of feedback is really useful - even a qualified
> Reviwed-by is useful. Total silence could mean anything.
>
>> However, as a general note I see a need for a generic ASoC hdmi codec
>> abstraction and I don't think this is generic enough. More of the audio
>> specific implementation and HDMI standard specific things should be pushed
>> away from the hdmi encoder driver (tda998x in this case) to the generic ASoC
>> side hdmi codec driver (or library).
>
> This is something I'm expecting, yes - what I don't have is a clear
> enough picture of how consistent the different hardware is in how it
> models these things.
>

After taking another look the patchesthere is not much functionality
that could be moved away from tda998x. It is just that the ASoC side
(and tda998x) could do more in terms of HDMI standard, but that is fine
because all that stuff can be added later if/when needed. However,
instantiating snd_soc_dai_driver etc. in DRM side makes a nasty
dependency between DRM and ASoC. All that stuff could be in ASoC side
and simple enum/bitfield parameters defining i2s/spdif selection could
be passed between DRM and ASoC side.


>> [1] I personally do not like the hdmi_get_cdev() approach. I would rather go
>> with only a library for registering from ASoC codec component under the HDMI
>> encoder device or a completely separate device with only a reference to the
>> HDMI encoder.
>
> It does seem somewhat complicated, yes. I don't know if matches idioms
> for DRM somehow?
>

Me neither. A more straight forward option would be adding an "audio
header" to the beginning of hdmi encoders drvdata. However, it would be
tempting to add a pointer for drvdata to snd_soc_dai_driver to add audio
specific driver data to any device that provides a DAI in addition to
other functionality. It could even simplify drivers for some audio only
devices with multiple DAIs.

Best regards,
Jyri


\
 
 \ /
  Last update: 2015-01-02 11:21    [W:0.032 / U:1.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site