[lkml]   [2015]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] phy: ti-pipe3: Disable clocks on system suspend

On 09/01/15 15:57, Kishon Vijay Abraham I wrote:
> Hi Roger,
> On Friday 19 December 2014 05:35 PM, Roger Quadros wrote:
>> On system suspend, the runtime_suspend() driver hook doesn't get
>> called and so the clocks are not disabled in the driver.
>> This causes the L3INIT_960M_GFCLK and L3INIT_480M_GFCLK to remain
>> active on the DRA7 platform while in system suspend.
>> Add suspend/resume hooks to the driver.
>> In case of pcie-phy, the runtime_suspend hook gets called after
> This contradicts with the first line of your commit message. Is pcie-phy driver
> is an exception?

Yes in the pcie-phy case it behaves differently. I'll rewrite the message.


> Thanks
> Kishon
>> the suspend hook so we introduce a flag phy->enabled to keep
>> track if our clocks are enabled or not to prevent multiple
>> enable/disables.
>> Move enabling/disabling clock code into helper functions.
>> Reported-by: Nishant Menon <>
>> Signed-off-by: Roger Quadros <>

 \ /
  Last update: 2015-01-12 10:41    [W:0.072 / U:1.580 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site