[lkml]   [2014]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] spi: omap2-mcspi: fix blatant abuse of the resource subsystem
On Fri, Jul 18, 2014 at 01:30:53PM +0200, Lothar Waßmann wrote:
> Aua. This really hurts. I wonder how this could ever be admitted to
> the Linux kernel...
> Further comments suppressed because the would most likely violate the
> CDA.
> If someone should not grasp what this patch does, they should consider
> what happens upon unloading/reloading the kernel module.
> Signed-off-by: Lothar Waßmann <>

I'm not going to apply this with a commit message such as the above.
Quite aside from the tone the fact that it doesn't describe the issue
is not helpful for review, one of the things done in review is to try to
check that the change has the intended effect.
[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2014-07-19 01:21    [W:0.073 / U:0.564 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site