lkml.org 
[lkml]   [2014]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] mm: memcontrol: Skip test_mem_cgroup_node_reclaimable() when no MAX_NUMNODES or not more than 1
From
OK, thanks. I shall try to send another patch to upstream kernel
within this month.

Send from Lenovo A788t.

Michal Hocko <mhocko@suse.cz> wrote:

>Hi,
>this has been fixed last week already
>http://marc.info/?l=linux-mm&m=141751847710864&w=2
>
>On Sat 06-12-14 06:27:57, Chen Gang wrote:
>> test_mem_cgroup_node_reclaimable() is only used when "MAX_NUMNODES > 1",
>> so move it into related quote.
>>
>> The related warning (with allmodconfig under parisc):
>>
>> CC mm/memcontrol.o
>> mm/memcontrol.c:1629:13: warning: 'test_mem_cgroup_node_reclaimable' defined but not used [-Wunused-function]
>> static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
>> ^
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> mm/memcontrol.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index c6ac50e..d538b08 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -1616,6 +1616,7 @@ static void mem_cgroup_out_of_memory(struct mem_cgroup *memcg, gfp_t gfp_mask,
>> NULL, "Memory cgroup out of memory");
>> }
>>
>> +#if MAX_NUMNODES > 1
>> /**
>> * test_mem_cgroup_node_reclaimable
>> * @memcg: the target memcg
>> @@ -1638,7 +1639,6 @@ static bool test_mem_cgroup_node_reclaimable(struct mem_cgroup *memcg,
>> return false;
>>
>> }
>> -#if MAX_NUMNODES > 1
>>
>> /*
>> * Always updating the nodemask is not very good - even if we have an empty
>> --
>> 1.9.3
>
>--
>Michal Hocko
>SUSE Labs
\
 
 \ /
  Last update: 2014-12-07 15:21    [W:0.019 / U:1.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site