lkml.org 
[lkml]   [2014]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/1] thermal: int3403: Delete a check before thermal_zone_device_unregister()
    From
    Date
    On Mon, 2014-12-01 at 05:50 +0100, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Mon, 1 Dec 2014 05:45:42 +0100
    >
    > The thermal_zone_device_unregister() function tests whether its argument
    > is NULL and then returns immediately. Thus the test around the call
    > is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    applied.

    thanks,
    rui
    > ---
    > drivers/thermal/int340x_thermal/int3403_thermal.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/thermal/int340x_thermal/int3403_thermal.c b/drivers/thermal/int340x_thermal/int3403_thermal.c
    > index 6e9fb62..790b8f6 100644
    > --- a/drivers/thermal/int340x_thermal/int3403_thermal.c
    > +++ b/drivers/thermal/int340x_thermal/int3403_thermal.c
    > @@ -293,8 +293,7 @@ static int int3403_sensor_add(struct int3403_priv *priv)
    > return 0;
    >
    > err_free_obj:
    > - if (obj->tzone)
    > - thermal_zone_device_unregister(obj->tzone);
    > + thermal_zone_device_unregister(obj->tzone);
    > return result;
    > }
    >




    \
     
     \ /
      Last update: 2014-12-08 05:41    [W:4.033 / U:2.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site