lkml.org 
[lkml]   [2014]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 1/20] mtd: s3c2410: fix misspelling of current function in string
    From
    On Sun, Dec 7, 2014 at 8:20 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
    > Replace a misspelled function name by %s and then __func__.
    >
    > s3c2410 is the name of the file, but using the exact function name should
    > make it easier to connect the error message to the code.
    >
    > This was done using Coccinelle, including the use of Levenshtein distance,
    > as proposed by Rasmus Villemoes.
    >
    > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    >
    > ---
    > The semantic patch is difficult to summarize, but is available in the cover
    > letter of this patch series.
    >
    > drivers/mtd/nand/s3c2410.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/mtd/nand/s3c2410.c b/drivers/mtd/nand/s3c2410.c
    > index 35aef5e..0a9c41f 100644
    > --- a/drivers/mtd/nand/s3c2410.c
    > +++ b/drivers/mtd/nand/s3c2410.c
    > @@ -948,7 +948,7 @@ static int s3c24xx_nand_probe(struct platform_device *pdev)
    >
    > cpu_type = platform_get_device_id(pdev)->driver_data;
    >
    > - pr_debug("s3c2410_nand_probe(%p)\n", pdev);
    > + pr_debug("%s(%p)\n", __func__, pdev);

    I think we can drop the line completely.
    We have ftrace to trace function calls...

    --
    Thanks,
    //richard


    \
     
     \ /
      Last update: 2014-12-08 00:01    [W:6.913 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site