lkml.org 
[lkml]   [2014]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 19/20] TTY: fix misspelling of current function in string
On Sun, 7 Dec 2014, Jeremiah Mahler wrote:

> Julia,
>
> On Sun, Dec 07, 2014 at 08:21:01PM +0100, Julia Lawall wrote:
> > Replace a misspelled function name by %s and then __func__.
> >
> > This was done using Coccinelle, including the use of Levenshtein distance,
> > as proposed by Rasmus Villemoes.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> > The semantic patch is difficult to summarize, but is available in the cover
> [...]
> > @@ -1458,7 +1458,7 @@ static void rp_wait_until_sent(struct tty_struct *tty, int timeout)
> >
> > orig_jiffies = jiffies;
> > #ifdef ROCKET_DEBUG_WAIT_UNTIL_SENT
> > - printk(KERN_INFO "In RP_wait_until_sent(%d) (jiff=%lu)...\n", timeout,
> > + printk(KERN_INFO "In %s(%d) (jiff=%lu)...\n", __func__, timeout,
> > jiffies);
> > printk(KERN_INFO "cps=%d...\n", info->cps);
> > #endif
> >
> More printk, pr_info, I'm sure you get the idea :-)

Well, these are drivers, so it should probably be dev_info, etc.

I have the impression that satisfying checkpatch would require a more
complicated change than the original patch.

I would still find it better to makes these changes in another patch
series.

julia


\
 
 \ /
  Last update: 2014-12-07 22:41    [W:0.048 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site