lkml.org 
[lkml]   [2014]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] staging: lustre: replace static value with define
On Sat, Dec 06, 2014 at 05:09:29PM +0000, Dilger, Andreas wrote:
> >
> >diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >index 74b4db9..7a55941 100644
> >--- a/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >+++ b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> >@@ -96,7 +96,7 @@ fld_proc_hash_seq_write(struct file *file,
> > char *name;
> > int i;
> >
> >- if (count > 80)
> >+ if (count > LUSTRE_MDT_MAXNAMELEN)
> > return -ENAMETOOLONG;
>
> Sorry for the late reply, but this has nothing to do with an MDT service
> name, so using this #define is misleading here. As I wrote in my other
> email, this only needs to be at most 8 characters.
>

I see that now, I will change that according to the other email.

Do you want me to redo this patch and still define the 80 as LUSTRE_MDT_MAXNAMELEN
but without this last part (just the define and the string length declaration), or
should we just let this go?

Thanks


\
 
 \ /
  Last update: 2014-12-07 00:21    [W:0.039 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site