lkml.org 
[lkml]   [2014]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Question about FIXME in au1xxx-ide.c
From
From: nick <xerofoify@gmail.com>
Date: Tue, 30 Dec 2014 12:31:04 -0500

> Greetings David,
> I am wondering about the fix me in the file,au1xxx-ide.c for
> the function,auide_ddma_init. While it's obvious to check the
> return code of the function called below the FIXME comment,it
> seems to be that there is more to this issue and therefore I
> have a few questions. The first being can this device fail and
> the system will function properly? The second question being don't
> we need to remove the device if the allocation fails in the creation
> of the data structures for it's use by the kernel as otherwise aren't
> we leaking memory?

I have no idea why the FIXME comment is there, I didn't write this
driver nor have I ever made any changes to it.


\
 
 \ /
  Last update: 2014-12-30 22:21    [W:1.542 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site