lkml.org 
[lkml]   [2014]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] smack: Fix a bidirectional UDS connect check typo
On 12/29/2014 6:34 AM, Zbigniew Jasinski wrote:
> The 54e70ec5eb090193b03e69d551fa6771a5a217c4 commit introduced a
> bidirectional check that should have checked for mutual WRITE access
> between two labels. Due to a typo subject's OUT label is checked with
> object's OUT. Should be OUT to IN.
>
> Signed-off-by: Zbigniew Jasinski <z.jasinski@samsung.com>

Applied to git://git.gitorious.org/smack-next/kernel.git#smack-for-3.20

> ---
> security/smack/smack_lsm.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index b774029..30f61f8 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -3313,7 +3313,7 @@ static int smack_unix_stream_connect(struct sock *sock,
>
> if (!smack_privileged(CAP_MAC_OVERRIDE)) {
> skp = ssp->smk_out;
> - okp = osp->smk_out;
> + okp = osp->smk_in;
> #ifdef CONFIG_AUDIT
> smk_ad_init_net(&ad, __func__, LSM_AUDIT_DATA_NET, &net);
> smk_ad_setfield_u_net_sk(&ad, other);
> @@ -3321,6 +3321,8 @@ static int smack_unix_stream_connect(struct sock *sock,
> rc = smk_access(skp, okp, MAY_WRITE, &ad);
> rc = smk_bu_note("UDS connect", skp, okp, MAY_WRITE, rc);
> if (rc == 0) {
> + okp = osp->smk_out;
> + skp = ssp->smk_in;
> rc = smk_access(okp, skp, MAY_WRITE, NULL);
> rc = smk_bu_note("UDS connect", okp, skp,
> MAY_WRITE, rc);



\
 
 \ /
  Last update: 2014-12-30 18:21    [W:0.042 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site