lkml.org 
[lkml]   [2014]   [Dec]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] staging: skein: Fixing various coding style problems
Mathieu,

On Mon, Dec 22, 2014 at 08:20:37AM -0700, mathieu.poirier@linaro.org wrote:
> From: Mathieu Poirier <mathieu.poirier@linaro.org>
>
> This patchset is fixing miscellaneous coding style problems as reported
> by checkpatch. More interesting is the removal of 'do {} while (0) loop'
> statements for single line macros. The following provides a guarantee the
> semantic of the object code hasn't been altered by the rectification:
>
> mpoirier@t430:~/work/kernel1$
> 146320048532 staging: skein: Fixing single statement macro checkpatch warning
> ef68ffa9fd3e staging: skein: Fixing trailing whitespace error
> 97bf6af1f928 Linux 3.19-rc1
> mpoirier@t430:~/work/kernel1$ git reset --hard 97bf6af1f928
> HEAD is now at 97bf6af1f928 Linux 3.19-rc1
> mpoirier@t430:~/work/kernel1$ make drivers/staging/skein/skein_block.o
> CHK include/config/kernel.release
> UPD include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> UPD include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CC drivers/staging/skein/skein_block.o
> mpoirier@t430:~/work/kernel1$ ./scripts/objdiff record drivers/staging/skein/skein_block.o
> mpoirier@t430:~/work/kernel1$ git reset --hard 146320048532
> HEAD is now at 146320048532 staging: skein: Fixing single statement macro checkpatch warning
> mpoirier@t430:~/work/kernel1$ make drivers/staging/skein/skein_block.o
> CHK include/config/kernel.release
> UPD include/config/kernel.release
> CHK include/generated/uapi/linux/version.h
> CHK include/generated/utsrelease.h
> UPD include/generated/utsrelease.h
> CALL scripts/checksyscalls.sh
> CC drivers/staging/skein/skein_block.o
> mpoirier@t430:~/work/kernel1$ ./scripts/objdiff record drivers/staging/skein/skein_block.o
> mpoirier@t430:~/work/kernel1$ ./scripts/objdiff diff 97bf6af1f928 146320048532
> mpoirier@t430:~/work/kernel1$
>
> New to this patchset:
> . Introduction of a cover letter that includes a scripts/objdiff snapshot
> . Splitting of the change set by semantic
>
> Mathieu Poirier (2):
> staging: skein: Fixing trailing whitespace error
> staging: skein: Fixing single statement macro checkpatch warning
>
> drivers/staging/skein/skein_block.c | 17 ++++-------------
> drivers/staging/skein/skein_generic.c | 1 -
> 2 files changed, 4 insertions(+), 14 deletions(-)

Awesome! For the whole series,

Acked-by: Jason Cooper <jason@lakedaemon.net>

thx,

Jason.


\
 
 \ /
  Last update: 2014-12-30 16:41    [W:0.045 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site