[lkml]   [2014]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v6 1/4] crypto: AF_ALG: add AEAD support
On Thu, Dec 25, 2014 at 11:01:47PM +0100, Stephan Mueller wrote:
> + err = -ENOMEM;

This should be EINVAL.

> + if (!aead_sufficient_data(ctx))
> + goto unlock;

So we're checking two things here, one that we have enough data
for AD and two we have the authentication tag. The latter is
redundant as the underlying implementation should be able to cope
with short input so we should only check the assoclen here.

Also this check should be moved to the sendmsg side as that'll
make it more obvious as to what went wrong.

PS we should add a length check for missing/partial auth tags
to crypto_aead_decrypt. We can then remove such checks from
individual implementations.

Email: Herbert Xu <>
Home Page:
PGP Key:

 \ /
  Last update: 2014-12-29 11:41    [W:0.155 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site