[lkml]   [2014]   [Dec]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] bfin_can: move the header file to arch independent location
On 12/29/2014 05:45 PM, Heinz-Jürgen Oertel wrote:
> Am Samstag, 27. Dezember 2014, 12:09:30 schrieb Oliver Hartkopp:
>> As bfin_can.c is the only user of defines from this include file just add the
>> needed(!) defines directly to bfin_can.c
> I often include also the yet unneeded definitions, e.g., for unused register or unused bit definitions.
> That makes it easier for someone else to add missing functionality, when later on needed.

Yes. This can be useful when you can imagine to add functionality into a
specific direction. But in this case there were tons of mailbox definitions
(always defined 32 times each) which we will not use in this way in the netdev

Just take a look into bfin_can.h and what is really used in bfin_can.c from
those defines and you will see.


 \ /
  Last update: 2014-12-29 19:01    [W:0.047 / U:0.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site