lkml.org 
[lkml]   [2014]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectAndoid Binder sneaking in [was Re: [GIT PULL] Staging driver patches for 3.19-rc1]
On Mon 2014-12-15 10:41:03, Greg KH wrote:
> On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote:
> > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote:
> > > I don't understand this kind of logic.
> > > a) Binder is considered a piece of shite.
> > > b) Google is working on a (hopefully sane) replacement.
> > >
> > > Why moving it out of staging then? What is the benefit?
> >
> > There is none, and Greg didn't even bother addressing the various
> > comments when this first came up.
>
> I thought I did, it was a long thread at the time, and I was on the road
> for 3 weeks, sorry if I missed something.

I pointed quite a lot of simple cleanups that could be done, but got
no feedback...

You should really post new version for review to people that commented
on the old one.

Plus "I set a rule that code must be cleaned in staging, and this is
not happening here, so it has to be moved to mainline, ignoring all
the usual rules" is quite interesting justification.

> > So a clear NAK from me on this one.
>
> You don't have to maintain it, I do, so why does it concern you?

You ignored even NAKs from people that maintain stuff this interfaces with.

Late NAK here, too, FWIW. Because it is going to be used as an
argument "it is in mainline, so it must be ok". You are willing to
ignore mainline rules for this; it should be way easier to ignore
single staging rule for this one.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2014-12-28 19:01    [W:0.051 / U:1.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site