lkml.org 
[lkml]   [2014]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] fs: overlayfs: Fix coding style issues, missing a blank line after declarations
From
Date
On Mon, 2014-12-29 at 02:49 +0000, Al Viro wrote:
> On Mon, Dec 29, 2014 at 02:39:39AM +0000, Al Viro wrote:
> > On Sun, Dec 28, 2014 at 11:56:53AM +0600, Alexander Kuleshov wrote:
> > > Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> > > ---
> >
> > For the record: anything of that sort against fs/*.c will be flushed down
> > the toilet where such valuable contributions belong. Don't even bother.
>
> Joe, could you please explain what has driven you to include that into
> scripts/checkpatch.pl and open the countless sphincters? Aren't we
> getting enough pointless patches as it is?

I don't care for that style actually.
It was Andrew Morton that wanted it used globally.

I wanted it to be a --strict test and only for
net/ and drivers/net/ where David Miller prefers
that style.

https://lkml.org/lkml/2014/3/6/550

> Al, stongly tempted to try and sneak a patch to checkpatch.pl declaring the
> lack of /* See Figure 1 */ within the first 10 lines of a function an offense
> against the Gods Of Style. Then sit back and watch the resulting spew...

Cool. Awaiting your patch...




\
 
 \ /
  Last update: 2014-12-29 04:21    [W:0.034 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site