lkml.org 
[lkml]   [2014]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 3/8] fs/9p: One function call less in v9fs_vfs_atomic_open() after error detection
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 28 Dec 2014 08:45:31 +0100

    The p9_client_clunk() function was called in one case by the
    v9fs_vfs_atomic_open() function during error handling even if the passed
    variable "fid" contained a null pointer.

    This implementation detail could be improved by the adjustment of a jump target.
    Let us delete also an unnecessary variable assignment there.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    fs/9p/vfs_inode.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
    index 81b945a..f568427 100644
    --- a/fs/9p/vfs_inode.c
    +++ b/fs/9p/vfs_inode.c
    @@ -873,8 +873,7 @@ v9fs_vfs_atomic_open(struct inode *dir, struct dentry *dentry,
    v9fs_proto_dotu(v9ses)));
    if (IS_ERR(fid)) {
    err = PTR_ERR(fid);
    - fid = NULL;
    - goto error;
    + goto out;
    }

    v9fs_invalidate_inode_attr(dir);
    --
    2.2.1


    \
     
     \ /
      Last update: 2014-12-28 22:01    [W:4.018 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site