lkml.org 
[lkml]   [2014]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] iio: imu: kmx61: fix simple_return.cocci warnings
From
On Sat, Dec 27, 2014 at 1:07 AM, kbuild test robot
<fengguang.wu@intel.com> wrote:
> drivers/iio/imu/kmx61.c:543:1-4: WARNING: end returns can be simpified
> drivers/iio/imu/kmx61.c:480:1-4: WARNING: end returns can be simpified if negative or 0 value
>
> Simplify a trivial if-return sequence. Possibly combine with a
> preceding function call.
> Generated by: scripts/coccinelle/misc/simple_return.cocci
>
> CC: Daniel Baluta <daniel.baluta@intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>
> kmx61.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> --- a/drivers/iio/imu/kmx61.c
> +++ b/drivers/iio/imu/kmx61.c
> @@ -540,11 +540,7 @@ static int kmx61_setup_new_data_interrup
> return ret;
> }
>
> - ret = kmx61_set_mode(data, mode, KMX61_ACC | KMX61_MAG, true);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return kmx61_set_mode(data, mode, KMX61_ACC | KMX61_MAG, true);
> }
>
> /**

Fixed with this patch:

http://marc.info/?l=linux-iio&m=141934100614777&w=2

Daniel.


\
 
 \ /
  Last update: 2014-12-27 09:21    [W:0.029 / U:4.812 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site