lkml.org 
[lkml]   [2014]   [Dec]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 11/37] perf tools: Introduce thread__comm_time() helpers
On Sat, Dec 27, 2014 at 2:00 AM, David Ahern <dsahern@gmail.com> wrote:
> On 12/24/14 12:15 AM, Namhyung Kim wrote:
>>
>> @@ -139,6 +161,16 @@ const char *thread__comm_str(const struct thread
>> *thread)
>> return comm__str(comm);
>> }
>>
>> +const char *thread__comm_time_str(const struct thread *thread, u64
>> timestamp)
>> +{
>> + const struct comm *comm = thread__comm_time(thread, timestamp);
>> +
>> + if (!comm)
>> + return NULL;
>> +
>> + return comm__str(comm);
>> +}
>> +
>
>
> thread__comm_str_time()? time_str suggests a time-based string as opposed to
> a comm_str based on time.

Will change - my naming sense is always awful. I'd be happy to hear
any naming suggestion. ;-)

Thanks,
Namhyung


\
 
 \ /
  Last update: 2014-12-27 07:01    [W:0.373 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site