lkml.org 
[lkml]   [2014]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/13] incorrect use of init_completion fixup
On Fri, Dec 26, 2014 at 09:06:10AM +0100, Nicholas Mc Guire wrote:
> The successive init_completion calls should be reinit_completion calls.
>
> patch against 3.19.0-rc1 linux-next
>
> Acked-by: Helge Deller <deller@gmx.de>
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>

Applied, thank you.

> ---
> drivers/input/keyboard/hil_kbd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/input/keyboard/hil_kbd.c b/drivers/input/keyboard/hil_kbd.c
> index 610a8af..5b152f2 100644
> --- a/drivers/input/keyboard/hil_kbd.c
> +++ b/drivers/input/keyboard/hil_kbd.c
> @@ -473,7 +473,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -482,7 +482,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> @@ -491,7 +491,7 @@ static int hil_dev_connect(struct serio *serio, struct serio_driver *drv)
> if (error)
> goto bail1;
>
> - init_completion(&dev->cmd_done);
> + reinit_completion(&dev->cmd_done);
> serio_write(serio, 0);
> serio_write(serio, 0);
> serio_write(serio, HIL_PKT_CMD >> 8);
> --
> 1.7.10.4
>

--
Dmitry


\
 
 \ /
  Last update: 2014-12-27 01:21    [W:0.049 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site