lkml.org 
[lkml]   [2014]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] x86: Fix multiple coding style issues
From
> Jeremiah Mahler <jmmahler@gmail.com>:
If you are looking for things to fix I suggest looking in the
drivers/staging directory. There are lots of things that need to be
fixed in there.

Ah sorry, read it incorrectly.

2014-12-26 23:09 GMT+06:00 Alexander Kuleshov <kuleshovmail@gmail.com>:
> Hello Jeremiah,
>
> Thank you for feedback. It is my first patches to kernel, so i have a
> some little questions:
>
>> Jeremiah Mahler <jmmahler@gmail.com>:
>> Alexander,
>>
>> On Fri, Dec 26, 2014 at 06:38:59PM +0600, Alexander Kuleshov wrote:
>>
>> Your description needs to be more specific than just "coding style
>> fixes". What type of problems did you fix? How did you find them?
>>
>
> There are some lines which more than 80 chars, I found it with
> scripts/checkpatch.pl.
> What is the best place to put this description? In commit message
> after first line?
>
>> Jeremiah Mahler <jmmahler@gmail.com>:
>> If you are looking for things to fix I suggest looking in the
>> drivers/staging directory. There are lots of things that need to be
>> fixed in there.
>
> So i must make this patch for kernel/git/gregkh/staging.git and resend
> it again or just to add to this thread?
> Or i'm wrong?
>
> Thank you.



--
_________________________
0xAX


\
 
 \ /
  Last update: 2014-12-26 18:41    [W:0.087 / U:0.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site