lkml.org 
[lkml]   [2014]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 05/37] perf tools: Create separate mmap for dummy tracking event
On Fri, Dec 26, 2014 at 7:08 AM, Jiri Olsa <jolsa@redhat.com> wrote:
> On Wed, Dec 24, 2014 at 04:15:01PM +0900, Namhyung Kim wrote:
>> When multi file support is enabled, a dummy tracking event will be
>> used to track metadata (like task, comm and mmap events) for a session
>> and actual samples will be recorded in separate files.
>>
>> Provide separate mmap to the dummy tracking event. The size is fixed
>> to 128KiB (+ 1 page) as the event rate will be lower than samples. I
>> originally wanted to use a single mmap for this but cross-cpu sharing
>> is prohibited so it's per-cpu (or per-task) like normal mmaps.
>
> maybe this needs to be applied after next patch?
> perf tools: Introduce perf_evlist__mmap_multi

Oops, sorry. it seems the code was mixed after huge number of
rebase.. The commit order is right but it just has a wrong hunk.


>
> I'm getting compile error:
>
> [jolsa@krava perf]$ make JOBS=1
> BUILD: Doing 'make -j1' parallel build
> CC util/evlist.o
> util/evlist.c: In function ‘perf_evlist__mmap_per_evsel’:
> util/evlist.c:937:9: error: ‘struct mmap_params’ has no member named ‘track’
> if (mp->track && perf_evsel__is_dummy_tracking(evsel)) {
> ^
> util/evlist.c: In function ‘perf_evlist__mmap’:
> util/evlist.c:1092:62: error: ‘use_track_mmap’ undeclared (first use in this function)
> if (evlist->mmap == NULL && perf_evlist__alloc_mmap(evlist, use_track_mmap) < 0)
> ^
> util/evlist.c:1092:62: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [util/evlist.o] Error 1
> make: *** [all] Error 2

Will fix, thanks
Namhyung


\
 
 \ /
  Last update: 2014-12-26 03:21    [W:3.994 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site