lkml.org 
[lkml]   [2014]   [Dec]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/37] perf tools: Create separate mmap for dummy tracking event
On Wed, Dec 24, 2014 at 04:15:01PM +0900, Namhyung Kim wrote:

SNIP

>
> union perf_event *perf_evlist__mmap_read(struct perf_evlist *evlist, int idx);
> -
> void perf_evlist__mmap_consume(struct perf_evlist *evlist, int idx);
> +struct perf_mmap *perf_evlist__mmap_desc(struct perf_evlist *evlist, int idx);
>
> int perf_evlist__open(struct perf_evlist *evlist);
> void perf_evlist__close(struct perf_evlist *evlist);
> @@ -211,6 +214,12 @@ bool perf_evlist__can_select_event(struct perf_evlist *evlist, const char *str);
> void perf_evlist__to_front(struct perf_evlist *evlist,
> struct perf_evsel *move_evsel);
>
> +/* convert from/to negative idx for track mmaps */
> +static inline int track_mmap_idx(int idx)
> +{
> + return -idx - 1;
> +}

hum, whats the logic with negative numbers in here?
you still access track_mmap array with this index no?

thanks,
jirka


\
 
 \ /
  Last update: 2014-12-25 23:21    [W:0.345 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site