lkml.org 
[lkml]   [2014]   [Dec]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 32/37] perf report: Add --multi-thread option and config item
Date
The --multi-thread option is to enable parallel processing so user can
force serial processing even for multi-file data. It default to false
but users also can changes this by setting "report.multi_thread"
config option in ~/.perfconfig file.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/Documentation/perf-report.txt | 3 +++
tools/perf/builtin-report.c | 18 +++++++++++++++---
2 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/tools/perf/Documentation/perf-report.txt b/tools/perf/Documentation/perf-report.txt
index dd7cccdde498..e00077a658c1 100644
--- a/tools/perf/Documentation/perf-report.txt
+++ b/tools/perf/Documentation/perf-report.txt
@@ -318,6 +318,9 @@ OPTIONS
--header-only::
Show only perf.data header (forces --stdio).

+--multi-thread::
+ Speed up report by parallelizing sample processing using multi-thread.
+
SEE ALSO
--------
linkperf:perf-stat[1], linkperf:perf-annotate[1]
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 796db514db31..6e260eaf3b1a 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -51,6 +51,7 @@ struct report {
bool mem_mode;
bool header;
bool header_only;
+ bool multi_thread;
int max_stack;
struct perf_read_values show_threads_values;
const char *pretty_printing_style;
@@ -82,6 +83,10 @@ static int report__config(const char *var, const char *value, void *cb)
rep->queue_size = perf_config_u64(var, value);
return 0;
}
+ if (!strcmp(var, "report.multi-thread")) {
+ rep->multi_thread = perf_config_bool(var, value);
+ return 0;
+ }

return perf_default_config(var, value, cb);
}
@@ -527,7 +532,7 @@ static int __cmd_report(struct report *rep)
if (ret)
return ret;

- if (file->is_multi) {
+ if (rep->multi_thread) {
rep->tool.sample = process_sample_event_multi;
ret = perf_session__process_events_mt(session, &rep->tool,
multi_report_init,
@@ -558,10 +563,10 @@ static int __cmd_report(struct report *rep)
}

/*
- * For multi-file report, it already calls hists__multi_resort()
+ * For multi-thread report, it already calls hists__multi_resort()
* so no need to collapse here.
*/
- if (!file->is_multi)
+ if (!rep->multi_thread)
report__collapse_hists(rep);

if (session_done())
@@ -770,6 +775,8 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
"Don't show entries under that percent", parse_percent_limit),
OPT_CALLBACK(0, "percentage", NULL, "relative|absolute",
"how to display percentage of filtered entries", parse_filter_percentage),
+ OPT_BOOLEAN(0, "multi-thread", &report.multi_thread,
+ "Speed up sample processing using multi-thead"),
OPT_END()
};
struct perf_data_file file = {
@@ -814,6 +821,11 @@ int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
report.queue_size);
}

+ if (report.multi_thread && !file.is_multi) {
+ pr_debug("fallback to single thread for single data file.\n");
+ report.multi_thread = false;
+ }
+
report.session = session;

has_br_stack = perf_header__has_feat(&session->header,
--
2.1.3


\
 
 \ /
  Last update: 2014-12-24 08:41    [W:0.415 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site