lkml.org 
[lkml]   [2014]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] proc: task_mmu: show page size in /proc/<pid>/numa_maps
On Mon, 22 Dec 2014, Dave Hansen wrote:

> > Remaining question here is: should we print out 'pagesize' deliberately
> > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE?
>
> I say print it unconditionally. Not to completely overdesign this, but
> I do think we should try to at least mirror the terminology that smaps uses:
>
> KernelPageSize: 4 kB
> MMUPageSize: 4 kB
>
> So definitely call this kernelpagesize.
>

Feel free to add my acked-by if this patch prints it unconditionally and
renames this to kernelpagesize per Dave. I agree we need to leave "huge"
for existing dependencies even though we have multiple possible hugepage
sizes.


\
 
 \ /
  Last update: 2014-12-23 00:01    [W:0.049 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site