lkml.org 
[lkml]   [2014]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel
    On Mon, Dec 22, 2014 at 11:58:43AM -0500, Alex Deucher wrote:
    > On Mon, Dec 22, 2014 at 6:11 AM, Oded Gabbay <oded.gabbay@amd.com> wrote:
    > > amdkfd driver can be compiled only in 64-bit kernel. Therefore, there is no
    > > point in trying to initialize amdkfd in 32-bit kernel.
    > >
    > > In addition, in case of specific configuration of 32-bit kernel, no modules and
    > > random kernel base, the symbol_request function doesn't work as expected - It
    > > doesn't return NULL if the symbol doesn't exists. That makes the kernel panic.
    > > Therefore, the as amdkfd doesn't compile in 32-bit kernel, the best way is just
    > > to return false immediately.
    > >
    > > Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
    >
    > Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

    Sorry but the patch is just bogus. X-bit only code is usually
    a very bad sign for the code. This is not windows programing after all.

    Even if you wanted to do a 64bit only driver -- which
    you probably don't -- the standard way would be to exclude
    it in Kconfig.

    Please root-cause why symbol_request doesn't work on 32bit
    and fix it properly.

    +rusty.

    -Andi



    \
     
     \ /
      Last update: 2014-12-22 20:21    [W:28.817 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site