[lkml]   [2014]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v3 2/5] ASoC: dwc: Iterate over all channels
On 12/22/14 13:53, Mark Brown wrote:
> On Fri, Dec 19, 2014 at 04:18:06PM +0000, Andrew Jackson wrote:
>> The Designware core can be configured with up to four stereo channels.
>> Each stereo channel is individually configured so, when the driver's
>> hw_params call is made, each requested stereo channel has to be
>> programmed.
> This is quite unclear to someone who doesn't know the hardware, is this
> a bug fix or a new feature? It looks like it's a fix...

It is a fix. In the Designware core, each stereo channel is configured
individually. So, when hw_params is called to configure N channels,
N/2 stereo channels need to be configured in the core. The existing
code doesn't do this and will only configure the highest numbered


 \ /
  Last update: 2014-12-22 15:41    [W:0.078 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site