lkml.org 
[lkml]   [2014]   [Dec]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/5] direct-io: don't dirty ITER_BVEC pages on read
On Sat, Dec 20, 2014 at 06:01:30AM +0000, Al Viro wrote:
> On Fri, Dec 19, 2014 at 07:18:26PM -0800, Omar Sandoval wrote:
> > Reads through the iov_iter infrastructure for kernel pages shouldn't be
> > dirtied by the direct I/O code.
> >
> > This is based on Dave Kleikamp's and Ming Lei's previously posted
> > patches.
>
> Umm...
>
> > + dio->should_dirty = !iov_iter_is_bvec(iter);
>
> dio->should_dirty = iter_is_iovec(iter);
>
> perhaps?

Mm, yeah, I'll do that. That helper snuck in without me noticing it... I
see that we can't do iov_iter_get_pages on an ITER_KVEC, so a kvec
doesn't work for blockdev_direct_IO anyways, right?

--
Omar


\
 
 \ /
  Last update: 2014-12-22 08:41    [W:0.047 / U:19.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site