lkml.org 
[lkml]   [2014]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] misc: cxl: sysfs.c: Remove unused function
    From
    Date
    On Sun, 2014-12-21 at 13:46 +0100, Rickard Strandqvist wrote:
    > 2014-12-21 5:05 GMT+01:00 Michael Neuling <mikey@neuling.org>:
    > >> Remove the function mmio_size_show() that is not used anywhere.
    > >
    > > Did you compile check this patch?
    > >
    > > drivers/misc/cxl/sysfs.c:291:74: error: ‘mmio_size_show’ undeclared here (not in a function)
    > >
    > > It's used here:
    > > static struct device_attribute afu_attrs[] = {
    > > __ATTR_RO(mmio_size),
    >
    > Hi
    >
    > Sorry about that.
    >
    > Strange because I compile everything as allyesconfig, allmodconfig and
    > allnoconfig.

    The allyes should have picked it up, so you must have done something wrong.

    Please be more careful with these attribute routines, they are not visible with
    grep.

    cheers




    \
     
     \ /
      Last update: 2014-12-22 05:21    [W:3.238 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site