lkml.org 
[lkml]   [2014]   [Dec]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status.
On 2014년 12월 20일 09:24, Pavel Machek wrote:

> Subject: charging.
>


(snip..)


>> --- a/include/linux/power/charger-manager.h
>> +++ b/include/linux/power/charger-manager.h
>> @@ -220,6 +220,7 @@ struct charger_desc {
>> * saved status of battery before entering suspend-to-RAM
>> * @charging_start_time: saved start time of enabling charging
>> * @charging_end_time: saved end time of disabling charging
>> + * @battery_status: Current battery status
>
> "current" for consistency.
>
>> */
>> struct charger_manager {
>> struct list_head entry;
>> @@ -237,6 +238,8 @@ struct charger_manager {
>>
>> u64 charging_start_time;
>> u64 charging_end_time;
>> +
>> + int battery_status;
>> };
>
> Should battery_status be some kind of enum?


Currently, it stores only enum of power_supply class's and it doesn't have
specified type. And also, I didn't want to make additional private enums.
I'd let it to be as it was.

Thanks,
Jonghwa

> Pavel
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
>




\
 
 \ /
  Last update: 2014-12-22 03:41    [W:3.377 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site