[lkml]   [2014]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/2] Properly fix sysfs_get_idlestate_count()
My previous commit 16b7c275c055 ("tools: cpupower: fix return checks for
sysfs_get_idlestate_count()") was not correct. After looking
at the changelog for cpupower I noticed that Thomas had changed the return of
sysfs_get_idlestate_count() to an unsigned int to simplify the code. The
problem is really that both he (in his original change) and I (in my new
change) missed the obvious that sysfs_get_idlestate_count()
can't return -ENODEV. It should just return 0 for "no c-states".

Patch 1 reverts my recent change and patch 2 fixes the problem correctly.

Sorry 'bout that Thomas. I should have caught that the the first time.

Cc: Thomas Renninger <>
Cc: Rafael J. Wysocki <>
Signed-off-by: Prarit Bhargava <>

Prarit Bhargava (2):
Revert "tools: cpupower: fix return checks for
Fix no idle state information return value

tools/power/cpupower/utils/cpuidle-info.c | 8 ++++----
tools/power/cpupower/utils/helpers/sysfs.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)


 \ /
  Last update: 2014-12-14 15:41    [W:0.045 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site