[lkml]   [2014]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c
On 12/14/2014 07:46 PM, nick wrote:
> Jens,
> After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without
> a breakage in the functions that call add_disk.

Please don't top post...

It's a big job, it requires properly checking and updating all block
drivers. But yes, that is what would be required in removing that TODO.

Jens Axboe

 \ /
  Last update: 2014-12-15 04:21    [W:0.023 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site