lkml.org 
[lkml]   [2014]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c
On 12/13/2014 08:09 PM, Nicholas Krause wrote:
> Removes unneeded fix me comment related to the function, add_disk needing error handling. The function clearly has supported this for a while and the comment is not longer needed
> for the function,add_disk in the file genhd.c.

But it doesn't, really. Proper error handling would be to unroll and
return the error, if it happens. Right now add_disk() can't return an error.

--
Jens Axboe



\
 
 \ /
  Last update: 2014-12-15 04:21    [W:0.037 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site